drivers: ethernet: adin1100: add support for hardware reset #97064
+53
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Boards/SoCs
area: Devicetree Bindings
area: Ethernet
platform: ADI
zephyrbot
requested review from
ClaCodes,
decsny,
galak,
lmajewski,
maass-hamburg,
MaureenHelm,
microbuilder,
ozersa,
pdgendt,
ttmut and
yasinustunerg
maass-hamburg
requested changes
Oct 6, 2025
drivers/ethernet/phy/phy_adin2111.c
Outdated
| if (ret < 0) { | ||
| return ret; | ||
| } | ||
| k_busy_wait(50); |
drivers/ethernet/phy/phy_adin2111.c
Outdated
| #if ADIN2111_RST_GPIO_SUPPORT | ||
| const struct phy_adin2111_config *config = dev->config; | ||
|
|
||
| if (!config->reset_gpio.port) { |
There was a problem hiding this comment.
Invert if and put the new logic inside, so the goto isn't needed anymore
drivers/ethernet/phy/phy_adin2111.c
Outdated
Comment on lines
107
to
109
| #if ADIN2111_RST_GPIO_SUPPORT | ||
| const struct gpio_dt_spec reset_gpio; | ||
| #endif /* ADIN2111_RST_GPIO_SUPPORT */ |
There was a problem hiding this comment.
put this after the mdio bus and not between bools.
maass-hamburg
requested changes
Oct 7, 2025
Add support for hardware reset via GPIO in the ADIN1100 PHY driver. The reset pin is configured via device tree using the reset-gpios property. Signed-off-by: Tim Pambor <[email protected]>
tpambor
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for hardware reset via GPIO in the ADIN2111 PHY driver.
The reset pin is configured via device tree using the reset-gpios property.